Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OS and TMCS into separate modules #265

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Move OS and TMCS into separate modules #265

merged 3 commits into from
Feb 20, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Feb 18, 2023 •
edited
Loading

Warning

This PR must be merged after #250

Description

This PR refactors some files.

Changes

  • Move Owen Shapley and TMCS into separate files.

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@mdbenito mdbenito added the cleanup when code is ugly or unreadable and needs restyling label Feb 18, 2023
@mdbenito mdbenito self-assigned this Feb 18, 2023
@mdbenito mdbenito mentioned this pull request Feb 18, 2023
Merged
4 tasks
@mdbenito mdbenito marked this pull request as ready for review February 19, 2023 01:02
@mdbenito mdbenito merged commit 9f9f87f into develop Feb 20, 2023
@mdbenito mdbenito deleted the refactor/tmcs branch February 20, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnesBenmerzoug AnesBenmerzoug AnesBenmerzoug approved these changes

Assignees

@mdbenito mdbenito

Labels
cleanup when code is ugly or unreadable and needs restyling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdbenito @AnesBenmerzoug